PHP - Notice: Undefined index: $_SESSION['login'] on header.php

Question

I'm having this error on my header.php which has all the html/bootstrap for my navigation bar.

<?php
        if($_SESSION['login']) {
        ?>
            <ul class="nav navbar-nav">
                <li><a href="dashboard.php">Dashboard</a></li>
                <li><a href="settings.php">Settings</a></li>
            </ul>
            <ul class="nav navbar-nav navbar-right">
                <p class="navbar-text">Hello, <?php $name; ?></p>
                <li><a href="logout.php">Log Out</a></li>
            </ul>
        <?php
        } else {
        ?>
            <ul class="nav navbar-nav navbar-right">
                <li><a href="login.php">Log In</a></li>
            </ul>
        <?php
        }
        ?>

It keeps showing on my navigation bar but it works fine:

"Notice: Undefined index: login in C:\xampp\htdocs\hotel-sys\includes\header.php on line 36"

It just keeps showing that notice. How can I solve it?

it means 'login' is not set. you can check like this if(isset($_SESSION['login'])) — Mubashar Iqbal, Jan 05 '18 at 11:28

score 1 · Answer 1 · answered Jan 05 '18 at 11:28

1

First you should check session variable has been started or not

if(isset($_SESSION['login'])) {
    // Your code
}

answered Jan 05 '18 at 11:28

Rajkumar R

1,097
8
14

score 1 · Answer 2 · answered Jan 05 '18 at 11:29

1

make sure you have session_start() in the top of your page and replace

<?php 

 if($_SESSION['login']) {
 ... 
 }
?>

by this

<?php 
 if(isset($_SESSION['login']) && $_SESSION['login']) 
 {
 ...
 }
?>

answered Jan 05 '18 at 11:29

azjezz

3,827
1
14
35

no need for second condition. $_SESSION['login'] – Mubashar Iqbal Jan 05 '18 at 11:30
depends , if he sets `login` to true if user is logged in and false when logged out , its needed – azjezz Jan 05 '18 at 11:31

score 1 · Answer 3 · answered Jan 05 '18 at 11:30

You can try the updated code as below.

<?php
        if(isset($_SESSION['login'])) {
        ?>
            <ul class="nav navbar-nav">
                <li><a href="dashboard.php">Dashboard</a></li>
                <li><a href="settings.php">Settings</a></li>
            </ul>
            <ul class="nav navbar-nav navbar-right">
                <p class="navbar-text">Hello, <?php $name; ?></p>
                <li><a href="logout.php">Log Out</a></li>
            </ul>
        <?php
        } else {
        ?>
            <ul class="nav navbar-nav navbar-right">
                <li><a href="login.php">Log In</a></li>
            </ul>
        <?php
        }
        ?>

PHP - Notice: Undefined index: $_SESSION['login'] on header.php

3 Answers3