First time login Null pointer exception (singleton pattern)

Question

I have a problem. Please take a look at these codes. When I click to login button first time it throws null pointer exception even I am typing correct username and password. But second time everything goes fine. How can I solve this issue? I have attached OracleDBConnection and Login servlet. Null pointer exception happens in OracleDBConnection file. Thanks for reading.

OracleDBConnection.java

    public class OracleDBConnection {

    private static volatile OracleDataSource instance = null;
    private static final DBPropertyController DB_PROPERTY = new DBPropertyController();
    private static final String URL = DB_PROPERTY.getProperty("url");
    private static final String USERNAME = DB_PROPERTY.getProperty("username");
    private static final String PASSWORD = DB_PROPERTY.getProperty("password");
    private static final String PORT = DB_PROPERTY.getProperty("port");

    private OracleDBConnection(){  
    }

    private static void initialize() {
        try {
            instance = new OracleDataSource();
            instance.setURL(URL);
            instance.setUser(USERNAME);
            instance.setPassword(PASSWORD);
            instance.setPortNumber(Integer.parseInt(PORT));
        } catch (SQLException ex) {
            Logger.getLogger(OracleDBConnection.class.getName()).log(Level.ERROR, ex);
        }
    }

    public static OracleDataSource getInstance() {
        OracleDataSource ods = OracleDBConnection.instance;

        if(ods == null) {
            synchronized(OracleDataSource.class){
                ods = OracleDBConnection.instance;
                if(ods == null) {
                    initialize();
                }
            }
        }
        return ods;
     }
   }

Login.java

    @WebServlet(name = "Login", urlPatterns = {"/login"})
    public class Login extends HttpServlet {

    private final LogController logger = new LogController();
    private final JWTController jwt_controller = new JWTController();

    @Override
    protected void doGet(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
        //processRequest(request, response);
    }

    @Override
    protected void doPost(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
        response.setContentType("text/html;charset=UTF-8");
        request.setCharacterEncoding("UTF-8");

        LoginController login_controller = new LoginController();
        HttpSession session = request.getSession(true);

        String username = request.getParameter("username");
        String password = request.getParameter("password");
        int role = 0;
        try {
            role = Integer.parseInt(request.getParameter("userrole"));
        } catch(NumberFormatException ex) {
            Logger.getLogger(Login.class.getName()).log(Level.ERROR, null, ex);
            role=0;
        }

        if(username!=null && password!=null && !username.equals("") && !password.equals("") && isRoleValid(role)){
            if(login_controller.validateLogin(username, password, role)) {
                // get manager object
                Manager manager = login_controller.getManager(username, password, role);
                long currentEpochTime = LocalDateTime.now().atZone(ZoneId.systemDefault()).toEpochSecond();
                // set manager object to session
                session.setAttribute("manager", manager);
                //generate token
                String token = jwt_controller.generateToken(username, MD5.generate(password), role);
                // set token to cookie
                Cookie cookie = new Cookie("token", token);
                // add cookie to response
                response.addCookie(cookie);
                // check password expire date
                if(manager.getPaswd_edate() > currentEpochTime) {
                    // signed in
                    response.getWriter().write("Signed in");
                } else {
                    // expired
                    response.getWriter().write("Expired");
                }
                // add log
                logger.addLog(username, "Signed in.", request.getRemoteHost(), request.getHeader("user-agent"));
            } else {
                response.getWriter().write("Error");
            }
        } else {
                response.getWriter().write("Error");
        }
    }

    private boolean isRoleValid(int role) {
        return role==0 || role==1 || role==2 || role==3;
    }

}

Which line is the NPE? The complete stacktrace should be included. — Jai, Feb 20 '18 at 09:06

score 0 · Accepted Answer · answered Feb 20 '18 at 09:09

You haven't mentioned where is your NPE, but I guess it is because your OracleDBConnection.getInstance() returns null object first time it is called.

Change your lines

synchronized(OracleDataSource.class){
        ods = OracleDBConnection.instance;
        if(ods == null) {
            initialize();
        }
    }

to

synchronized(OracleDataSource.class){
        if(ods == null) {
            initialize();
        }
        ods = OracleDBConnection.instance;
    }

Thank you. It worked. How I missed that... – user8920693 Feb 20 '18 at 09:51 — user8920693, Feb 20 '18 at 09:51

First time login Null pointer exception (singleton pattern)

1 Answers1