1

LoginRequiredMixin works great on other class based views. Also the Form Tools FormPreview works fine. But when I try to use both together, then the LoginRequiredMixin gets ignored.

This is even the case if I use the most basic example from form tools and the Django documentation.

Two things I found strange (but this does not necessary be the reason):

  • "This mixin should be at the leftmost position in the inheritance list." This sounds like there is some internal hack that breaks if someone does something irregular. There is no explanation why.
  • The Form Tools view should be called itself and not the method .as_view(), which is off standard again.

Is this a bug? What can I do?

Alasdair
  • 298,606
  • 55
  • 578
  • 516
mogoh
  • 992
  • 2
  • 7
  • 27
  • [This question](https://stackoverflow.com/questions/10018757/how-does-the-order-of-mixins-affect-the-derived-class) might help you understand why the mixin should be leftmost. It's not an internal hack -- you just want the login check to run *before* the view runs. – Alasdair Jun 04 '18 at 14:56
  • Very helpful, thank you. – mogoh Jun 04 '18 at 15:15

1 Answers1

5

FormPreview is not a generic class based view, so you can't use it with mixins like LoginRequiredMixin.

You can use the login_required decorator when you include the form preview instance in your URL patterns:

from django.contrib.auth.decorators import login_required

url_patterns = [
    url(r'^form-handler/$', login_required(MyFormPreview(SomeModelForm))),
]
Alasdair
  • 298,606
  • 55
  • 578
  • 516