Modified random number generator

Asked Oct 16 '12 at 14:58

Active Oct 16 '12 at 14:58

Viewed 61 times

Possible Duplicate:
Random numbers with different probabilities

I have to write a function that will take a parameter p = either 0.25 or 0.5 or 0.75 and return yes / no with Probablity(yes) = p. As I have uniform random number generator rand() my idea is

//representing yes -> '1' and no -> '0'
char myRandom(double d){
    char array[4];
    if (p(yes) == 0.25) strcpy(arr,"1000");
    if (p(yes) == 0.50) strcpy(arr,"1100");
    if (p(yes) == 0.75) strcpy(arr,"1110");
    return arr[rand(0,4)];
}

I know it is not efficient if there are much more probablities. But other than this is there any wrong in my idea? If there is then where?

edited May 23 '17 at 11:48

Community

asked Oct 16 '12 at 14:58

taufique

2,701
1
26
40

You guys appear to be taking the same course. – Luchian Grigore Oct 16 '12 at 15:00
did you intend `if (p == 0.25)` etc? – Vlad Oct 16 '12 at 15:00
One error is that your array is not big enough because strcpy copies a trailing null byte. Up the size to 5, or use memcpy. – john Oct 16 '12 at 15:02

Modified random number generator

0 Answers0