CI accessing property on interface

Question

I'm using scrutinizer to analyze my code. And almost everything has been fixed but I can't seem to fix this issue.

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

I see the problem beceause it's an interface that propery does not exist, but my code works just fine. So how can I let this code pass when I analyze my code?

Thanks

Edit

Got the error on these lines (and some other files are almost the same)

$this->tracert->log(
            'users',
            $this->auth->user()->id,
            $this->auth->user()->id,
            'Login'
        );

The constructor of that class

 /**
 * @param \Illuminate\Contracts\Auth\Guard $auth
 * @param \jorenvanhocht\Tracert\Tracert $tracert
 */
public function __construct(Guard $auth, Tracert $tracert)
{
    parent::__construct($auth);
    $this->tracert = $tracert;
}

constructor of my base controller:

public function __construct(Guard $auth)
{
    $this->auth = $auth;
    $this->config = objectify(config('blogify'));
    $this->auth_user = $this->auth->check() ? $this->auth->user() : false;
}

The used contract https://github.com/illuminate/contracts/blob/master/Auth/Guard.php

If a look at definition *public function log($model, $row, $user_id, $action = 'created')*, dont know why you need *$row* and *$user_id*, but ok... I changed it to `log($model, \Illuminate\Contracts\Auth\Authenticatable $user, $action = 'created')` and in method pull $user()->getAuthIdentifier() as id — venca, Jun 11 '15 at 09:02
Seems like getAuthIdentifier() fixed the problem. But how would you go over fixing it on a relation like this: $this->auth->user()->role->name or on another column then the id like: $this->auth->user()->role_id ? — Joren Van Hocht, Jun 11 '15 at 09:40
problem is pretty clear scrutinizer doesnt know if the attrib is in your instance. i would try to cover *problematic code* in `if ($object instanceof YourClass)`. I assume `$object = new YourClass()`. — venca, Jun 11 '15 at 10:20

score 6 · Accepted Answer · edited Jun 11 '15 at 11:08

6

To fix the problem for the id of the authenticated user, you should use:

$this->auth->user()->getAuthIdentifier()

Interface consists of methods. You are accessing attribute directly. eg $foo->id instead of $foo->getId(). And you have to add new method to interface of course.

The workaround is to say to scrutinizer, that $object is instance of desired class.

if ($object instanceof MyClass) {
    //
}

edited Jun 11 '15 at 11:08

Joren Van Hocht

845
1
9
21

answered Jun 11 '15 at 07:20

venca

1,196
5
18

I see what you mean, but the interface/contract that is used is core of Laravel, so any idea how to solve it without editing the core? Or am I missing something? – Joren Van Hocht Jun 11 '15 at 08:09
I would suggest to make PR on github. – venca Jun 11 '15 at 08:18
mmm don't really think that that is an option. I can be wrong off course – Joren Van Hocht Jun 11 '15 at 08:33

CI accessing property on interface

1 Answers1