How do I Improve this code

Question

This is the original code.

def d_to_b(dec, bin="")
    dec = dec.to_i
    if (dec < 2)
        bin += dec.to_s
        bin = bin.reverse
        return bin
    else
        a = dec%2
        bin += a.to_s
        d_to_b(dec/2, bin)
    end
end

def b_to_d(bin)
    bin = bin.to_s
    a = (bin.length - 1)
    dec = 0
    i = 0
    while(i <= a)
        dec += (bin[i].to_i)*(2**(a-i))
        i += 1
    end
    return dec
end

I want to improve the code. make it faster, and shorten it. Any help, perhaps a more efficient algorithm.

Oh, looks like a duplicate. http://stackoverflow.com/questions/2339695/how-to-convert-a-string-or-integer-to-binary-in-ruby — Schwern, Aug 12 '16 at 23:03
You need to first state the problem you are trying to solve rather than asking the reader to try to figure that out by studying your code. You should read through the SO [faq](http://stackoverflow.com/help) — Cary Swoveland, Aug 13 '16 at 01:26

score 4 · Accepted Answer · edited Aug 12 '16 at 23:12

4

Ruby has built in methods to do base conversions. Fixnum#to_s will take a base to convert to, and String#to_i will take a base to convert from.

$ ruby -e 'puts 12.to_s(2); puts "1100".to_i(2)'
1100
12

Ruby does this work in C, you're not going to do it faster.

If you want to see how Ruby does it, have a look at rb_fix2str() and rb_cstr_parse_inum(). They're not simple.

edited Aug 12 '16 at 23:12

the Tin Man

158,662
42
215
303

answered Aug 12 '16 at 22:50

Schwern

153,029
25
195
336

How do I Improve this code

1 Answers1