Result of function is too small. How to fix this?

Question

The result of this function is too small. I'm not sure where the problem is or how to fix it. Please address both

def get_n_numbers(n):
    ''' Return the sum of n random numbers from 1 through 4'''
    import random
    total = 0
    for i in range(n):
        mynumber = random.randint(1,4)
        total = total + mynumber

return total

Because you have `return total` _inside_ a `for` loop. Take it out of the loop. Your function breaks out immediately when it hits a `return` so you never get more than 1 iteration. — roganjosh, Jun 10 '19 at 14:14

score 0 · Answer 1 · answered Jun 10 '19 at 14:16

Just move the return outside the loop, so that the function doesn't stop and return after the first pass of the loop:

def get_n_randoms(n):
    ''' Return the sum of n random numbers from 1 through 4'''
    import random
    total = 0
    for i in range(n):
        mynumber = random.randint(1,4)
        total = total + mynumber
    return total

sum_of_10 = get_n_randoms(10)
print(sum_of_10)

score 0 · Accepted Answer · answered Jun 10 '19 at 14:16

Your function is returning on the first loop iteration. So move the return outside of the for loop block to return the actual total sum of all loops.

def get_n_randoms(n):
    ''' Return the sum of n random numbers from 1 through 4'''
    import random
    total = 0
    for i in range(n):
        mynumber = random.randint(1,4)
        total = total + mynumber
    return total   # < ---- right here see how it aligns with the start of the function block

score 0 · Answer 3 · answered Jun 10 '19 at 14:17

0

Your return is inside your for loop so your not hitting more than one iteration.

answered Jun 10 '19 at 14:17

Arnaud Dorval

66
7

Result of function is too small. How to fix this?

3 Answers3